avoid calling path.node when we already have the reference#1440
Merged
avoid calling path.node when we already have the reference#1440
path.node when we already have the reference#1440Conversation
Janther
added
performance
Janther
force-pushed
the
cleaning-path-node-calls
branch
from
730e53e to
5f98a91
Compare
fvictorio
approved these changes
Mar 8, 2026
Janther
force-pushed
the
cleaning-path-node-calls
branch
from
5f98a91 to
fac35c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are a few functions that required the
pathin order to access thepath.nodegiven that we already had the exact pointer to the node from the function that was calling.after some profiling I reached the conclusion that passing the extra parameter to the function was faster than getting the
nodefrom thepath.